Multicall gas improvement

stakewise · Oct 1, 2023 · 966f394 · 966f394
1 parent dfa2be4
commit 966f394
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/contracts/base/Multicall.sol b/contracts/base/Multicall.sol
@@ -13,8 +13,9 @@ import '../interfaces/IMulticall.sol';
 abstract contract Multicall is IMulticall {
   /// @inheritdoc IMulticall
   function multicall(bytes[] calldata data) external override returns (bytes[] memory results) {
-    results = new bytes[](data.length);
-    for (uint256 i = 0; i < data.length; ) {
+    uint256 dataLength = data.length;
+    results = new bytes[](dataLength);
+    for (uint256 i = 0; i < dataLength; ) {
       (bool success, bytes memory result) = address(this).delegatecall(data[i]);
 
       if (!success) {

diff --git a/test/__snapshots__/EthGenesisVault.spec.ts.snap b/test/__snapshots__/EthGenesisVault.spec.ts.snap
@@ -17,14 +17,14 @@ Object {
 exports[`EthGenesisVault pulls assets on claim exited assets 1`] = `
 Object {
   "calldataByteLength": 68,
-  "gasUsed": 64329,
+  "gasUsed": 64321,
 }
 `;
 
 exports[`EthGenesisVault pulls assets on multiple validators registration 1`] = `
 Object {
   "calldataByteLength": 3716,
-  "gasUsed": 682468,
+  "gasUsed": 682648,
 }
 `;
 

diff --git a/test/__snapshots__/EthVault.register.spec.ts.snap b/test/__snapshots__/EthVault.register.spec.ts.snap
@@ -3,7 +3,7 @@
 exports[`EthVault - register multiple validators succeeds 1`] = `
 Object {
   "calldataByteLength": 3652,
-  "gasUsed": 723005,
+  "gasUsed": 722975,
 }
 `;
 

diff --git a/test/__snapshots__/KeeperValidators.spec.ts.snap b/test/__snapshots__/KeeperValidators.spec.ts.snap
@@ -3,14 +3,14 @@
 exports[`KeeperValidators register multiple validators succeeds 1`] = `
 Object {
   "calldataByteLength": 3716,
-  "gasUsed": 724184,
+  "gasUsed": 724154,
 }
 `;
 
 exports[`KeeperValidators register multiple validators succeeds 2`] = `
 Object {
   "calldataByteLength": 3716,
-  "gasUsed": 632505,
+  "gasUsed": 632475,
 }
 `;