Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test flight main views navigation changes #360

Conversation

Korede612
Copy link

Pull Request Title

Main views navigation changes / over dashboard #343

Description

This pull request addresses the Main views navigation changes / over dashboard in Issue #343.

The following are the addressed issues:

  • The following will now show up over the dashboard in the same window instead of showing as new windows popping up.
    • Profile
    • Transactions
    • Create Tribe
    • Add new Contact

Changes Made

  • Storyboard:
    • Created a storyboard for handle the view presentation (as child VC)
    • Update StoryboardScenes file to enable creating a ViewController from storyboard
    • The DashboardViewController's Storyboard is also updated
  • DashboardPresenterViewController:
    • The ViewController (DashboardPresenterViewController) connected to the storyboard is also updated
  • DashboardViewController:
    • The DashboardViewController is also updated
      -WindowsManager:
    • Added a method to show the ViewController in the WindowsManager
    • Update the following method to use the new method created:
      • showProfileWindow
      • showTransationsListWindow
      • showContactWindow
      • showInviteCodeWindow

@tomastiminskas
Copy link
Contributor

@Korede612 I was reviewing your changes and here are the corrections needed:

UI adjustments:

Header height, font size and close button position needs to be adjusted based on Figma designs on this link https://www.figma.com/file/suipHjIGKg38rbWo0qHGqV/Desktop-Design-System---Dark-Version?type=design&node-id=3435-26914&mode=design&t=CrSCXAg76WWHu0vj-0

  1. Font size of header label (should be 22 instead of 24)
  2. Position of close button (should be closer to the edges of the view)
  3. Height should be 80 instead of 90
  4. Remove bottom empty space on blue container and check background color of all VC presented there. I saw a grey background when scrolling to the very bottom on profile (screenshot attached). The bottom padding space should be part of each View Controller view so it won't be outside of the scroll view content
  5. Blue container view should have rounded corners as on the designs
  6. Check top and bottom margin of the blue container view (they are larger on the designs)
  7. If the content of the view is small, the blue container view should be smaller (like on AddFriendViewController), not filling the entire height of the window. The designs show the max height in case the content is larger that the height of the windows
  8. The separator line between the header and the content should be there just if the content is scrollable. Otherwise it shouldn't be there
  9. Check blurred effect details on designs and try to match them. If not possible, then let's leave it as it is
Screenshot 2024-04-15 at 10 46 50

Navigation adjustments:

You can check this tutorial for getting designs details from Figma: stakwork/sphinx-ios#435

@Korede612
Copy link
Author

@tomastiminskas Thanks for the feedback.

All the mentioned fixes has been implemented

@tomastiminskas tomastiminskas changed the base branch from test-flight to tt/feature/main-navigation-views April 16, 2024 15:40
@tomastiminskas tomastiminskas merged commit 9c315e6 into stakwork:tt/feature/main-navigation-views Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants