-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MapTiler SDK #199
base: main
Are you sure you want to change the base?
Conversation
@petr-hajek Thanks for this! We'll be taking a look at this soon. |
It's my first PR into this project and for full transparency, MapTiler is my client so I am open to any feedback. Thanks a lot. Anyway, this is a great tool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good here!
I left a long explainer for this, but basically I think we may need to switch the order of our ||
conditional here to be style || url
as opposed to how it is now.
We'll also want to QA that change and make sure there's no weird side effects.
cc @ebrelsford
Sorry for not responding. I was loaded with other things, but I'll try get back to this soon, thanks for the feedback. |
Sorry it took me so long. I moved the url normalization to a separate file and apply it in the GlMap component as well. It now works with Maplibre and Mapbox renderer as well. |
Description
As a user of MapTiler SDK & MapTiler maps I'd like an easy way how to compare also MapTiler maps.
With this PR I can add MapTiler API key to the config (similar to MapBox). I can also use MapTiler SDK as a renderer (it's almost the same like MapLibre).
I removed the duplicate code in Map.svelte
QA steps
Probably some basic regression of MapLibre & MapBox but should not be affected
Author checklist
Create the PR
After approval
main
into your branch, resolve any conflictsmain