New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace string array with enum for PreferencePaneId and add generic type to Dropdown component #2890

Open

besdar wants to merge 1 commit into standardnotes:main from besdar:preference-pane-id-enum

besdar commented Jan 17, 2025

This pull request makes two improvements to the codebase:

Replaces the existing string array PREFERENCE_PANE_IDS with an enum PreferencePaneId to improve type safety and maintainability.
Adds a generic type T to the Dropdown component to improve type safety and flexibility.

besdar force-pushed the preference-pane-id-enum branch from 571bc4f to 3951a31 Compare

January 17, 2025 17:36


          replacing PREFERENCE_PANE_IDS with enum

c7b3ddc

besdar force-pushed the preference-pane-id-enum branch from 3951a31 to c7b3ddc Compare

January 17, 2025 18:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet