Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to the latest Ruby version #12

Closed
wants to merge 3 commits into from

Conversation

parndt
Copy link
Contributor

@parndt parndt commented May 30, 2024

Type of PR (feature, enhancement, bug fix, etc.)

Enhancement

Description

I noticed while investigating #9 that the Ruby version is hardcoded.

In lieu of fixing that just yet I thought I could at least bring it up to date.

Checklist

  • My code follows the style guidelines of this project
  • Actions are passing

I noticed while investigating standardrb#9 that the Ruby version is hardcoded.

In lieu of fixing that just yet I thought I could at least bring it up to date.
@parndt
Copy link
Contributor Author

parndt commented May 30, 2024

@searls oh dear - the project tries to bundle but there is no Gemfile, and it tries to run bin/rspec but that file doesn't exist.

Would you like me to set those things up?

@searls
Copy link
Contributor

searls commented May 30, 2024

Full disclosure: I've never actually used this action but I very much want to, and I fully believe it needs work to be useful.

If you'd be willing to help out in pushing it forward I would really appreciate. Since I know and trust you (as co-maintainer of the Emoruby programming language), feel free to do whatever has to be done

@parndt
Copy link
Contributor Author

parndt commented May 30, 2024

(as co-maintainer of the Emoruby programming language)

✨ 💖 ✅

sounds good, I'll investigate..

@searls
Copy link
Contributor

searls commented Jun 17, 2024

Obviated by #15

@searls searls closed this Jun 17, 2024
@parndt parndt deleted the patch-1 branch June 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants