-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bitwuzla code for new API #347
Update Bitwuzla code for new API #347
Conversation
This reverts commit eced881.
@yoni206 I think this is good to go now, please take a look when you have the chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of this. It looks fine, though I am wondering if this would be a good opportunity to add a corresponding test directory to here https://github.com/stanford-centaur/smt-switch/tree/main/tests (I think bitwuzla is the only solver that doesn't have one, right?)
I can do that, but this PR is already big enough, so maybe let's merge that separately. |
Actually, what are the solver-specific tests testing that the top-level ones aren't? They mostly just seem a lot older. |
You are right, it is not really related to this PR. Merged. Thanks for updating bitwuzla! |
Yay, of course, thanks for reviewing! And thank you to @samanthaarcher0! :) |
Add support for the new C++ API of Bitwuzla