Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all currently existing bitwuzla options #355

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

CyanoKobalamyne
Copy link
Collaborator

No description provided.

@yoni206
Copy link
Collaborator

yoni206 commented Oct 9, 2024

Thanks for this.
I am not sure however how realistic it is to keep track on all options of all solvers when updating their versions.
Can we, instead, do here what we already do for, e.g., cvc5?

solver.setOption(cvc5option, cvc5value);

That is, just trying to set the option as given and complain if it does not work? Would any bitwuzla option fail this way?

@CyanoKobalamyne
Copy link
Collaborator Author

That is, just trying to set the option as given and complain if it does not work? Would any bitwuzla option fail this way?

Okay, I updated the code to do just that.

Copy link
Collaborator

@yoni206 yoni206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@yoni206 yoni206 merged commit 083437d into main Oct 10, 2024
24 checks passed
@CyanoKobalamyne CyanoKobalamyne deleted the bitwuzla-options branch October 11, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants