Add AudioCaps scenario #3137
Merged
Add AudioCaps scenario #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImKeTT
reviewed
Nov 7, 2024
src/helm/benchmark/scenarios/audio_language/audiocaps_senario.py
Outdated
Show resolved
Hide resolved
ImKeTT
reviewed
Nov 7, 2024
src/helm/benchmark/scenarios/audio_language/audiocaps_senario.py
Outdated
Show resolved
Hide resolved
ImKeTT
reviewed
Nov 7, 2024
| taxonomy: | ||
| task: audio captioning | ||
| what: audio clips in the wild | ||
| who: youtube |
There was a problem hiding this comment.
I think it's real speakers from youtube videos, right? How about just change this to real speakers?
ImKeTT
requested changes
Nov 7, 2024
ImKeTT
reviewed
Nov 7, 2024
|
|
||
| for row in tqdm(load_dataset("Olivia714/audiocaps", cache_dir=output_path, split=TEST_SPLIT)): | ||
| ensure_file_downloaded(source_url=AudioCapsScenario.DOWNLOADING_URL, target_path=data_dir, unpack=True) | ||
| assert os.path.exists(data_dir), f"Download the wav_files from {AudioCapsScenario.DOWNLOADING_URL}" |
There was a problem hiding this comment.
Could you delete this line? This is redundant since we're using ensure_file_downloaded
ImKeTT
reviewed
Nov 7, 2024
| @@ -297,6 +297,6 @@ run_groups: | |||
| taxonomy: | |||
| task: audio captioning | |||
| what: audio clips in the wild | |||
| who: youtube | |||
| who: sound and human voices from real-life scenes | |||
There was a problem hiding this comment.
how about change to real speakers?
ImKeTT
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scenario_state.json
Add AudioCaps scenario.