fix wandb key #785
Merged
fix wandb key #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
reviewed
Nov 5, 2024
src/levanter/infra/ray_tpu.py
Outdated
| @@ -583,6 +589,16 @@ def _make_unique_job_id(client, run_id): | |||
| return job_id | |||
|
|
|||
|
|
|||
| def _deep_merge_envs(env1, env2): | |||
There was a problem hiding this comment.
oh sorry, i had pycharm inline it but it kept the declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out ray doesn't merge things when you use .options, which... what.