-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP switch from quinine to yahp #133
base: main
Are you sure you want to change the base?
Conversation
Oh man we'll have to change the graphic on the front page ... |
Any particular reason you favor yahp over quinine ? I guess overall yahp has a team maintaining/developing it and we probably have some degree of freedom to directly alter it if we have great ideas ... quinine just has one person and we probably have more freedom to alter it but still at the discretion of Karan ... so I don't really care either way |
In addition to the points you mention, I like types and dataclasses that my IDE will recognize. I also ran into a limitation in quinine/cerberus a while back (though I've forgotten by now exactly what it was. it had to do with lists) Both Cerberus and Quinine also seems somewhat abandoned? If it were just quinine, I'd just take it over if need be, but with cerberus also being abandoned that seemed not good. |
Closes #130 . Our friends at Mosaic have created a nice little config library called yahp. It's not perfect, but it's like 90% of what I'd want. All the config is in dataclasses now, and the yaml barely had to change.
As a bonus I made it so that we can handle just about every argument from TrainingArguments in HF and it's auto-synced with updates to hugging face.
I still need to:
Fixes Issues
#130
Unit test coverage
Are there unit tests in place to make sure your code is functioning correctly?
^^ situation is no worse, and we have some semblance of static type checking sometimes
Known breaking changes/behaviors
Configs need to change a bit, but mostly just removing "nulls" that should just be unspecified rather than null, imho.