-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New RM] Add AzureAISearch #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution! We are happy to integrate this once you fix the nits.
@shaoyijia requested changes have been applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this!
[New RM] Add AzureAISearch
Goal
Add RM support for Azure AI Search. Allows the use of custom datasets made available through Azure AI Search.
Changes
requirements.txt
to includeazure-search-documents
. This SDK wraps Azure's AI Search functionality.rm.py
to includeAzureAISearch
implementation.run_storm_wiki_gpt.py
, to includeAzureAISearch
support.README.md
to include the new retrieval module componentChange Questions / Comments
We could do something akin to what was done for Google Search support: rather than install as part of
requirements.txt
, have the RM fail unless the user installs the proper pypi library.Generated Files
I've attached a zip of the artifacts generated running the
run_storm_wiki_gpt.py
using the new rm. Data for the article sourced from part of dFusion's Genesis Knowledge Pool made available through Azure AI Search. Files in the zip include:Formal_Verification_In_Smart_Contract_Development.tar.gz