Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, Fix Build #143

Merged
merged 10 commits into from
Jan 3, 2024
Merged

Fix CI, Fix Build #143

merged 10 commits into from
Jan 3, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 2, 2024

The main problem: pnpm build fails.

Solution:

  • have turbo do everything.
    this is literally 2 lines of package.json changes (but applied to each package.json)

The whole PR:

  • use correct ci.yml (to read our tooling versions from package.json)

  • upgrade esyes (so that errors correctly fail the invocation)

  • add turbo.json config

  • fix the top level build and lint:fix scripts

  • run this script:

    script-that-adds-build-and-prepack
    import { project, packageJson } from "ember-apply";
    
    for (let workspace of await project.getWorkspaces()) {
      let manifest = await packageJson.read(workspace);
    
      if (manifest.private || !manifest.name) continue;
    
      let hasRollup =
        manifest?.devDependencies?.rollup || manifest?.dependencies?.rollup;
    
      if (!hasRollup) {
        continue;
      }
    
      try {
        await workOn(workspace);
      } catch (e) {
        console.error(workspace);
        console.error(e);
      }
    }
    
    async function workOn(workspace) {
      await packageJson.modify((json) => {
        json.scripts ||= {};
        json.scripts.build = "rollup -c";
        json.scripts.prepack = "pnpm build";
      }, workspace);
    }

Copy link

stackblitz bot commented Jan 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

socket-security bot commented Jan 2, 2024

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-config-prettier 9.1.0 None +0 20.8 kB lydell
esyes 1.0.1...1.0.2 network +1/-1 426 kB
vitest 1.0.0-beta.4...1.1.0 None +3/-0 1.39 MB oreanno

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review January 3, 2024 21:47
@wycats wycats merged commit 0b31af0 into main Jan 3, 2024
8 checks passed
@wycats wycats deleted the try-to-prevent-the-build-from-breaking branch January 3, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants