Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPEC - Decide on rules for documents #135

Closed
amorton opened this issue Feb 16, 2023 · 4 comments · Fixed by #170
Closed

SPEC - Decide on rules for documents #135

amorton opened this issue Feb 16, 2023 · 4 comments · Fixed by #170
Assignees
@amorton
Labels
specifications Work needed on specifications

Comments

@amorton
Copy link
Contributor

amorton commented Feb 16, 2023

What rules do we have for documents, e.g.

Max doc depth
Max array length
Max doc size
Key name restrictions, e.g. can I name a field "$size" ?
Db and collection names
Others ?

Will create another ticket to implement the rules, we can put them in this ticket first.
@amorton amorton added the specifications Work needed on specifications label Feb 16, 2023
@amorton amorton mentioned this issue Feb 16, 2023
Closed
@amorton
Copy link
Contributor Author

amorton commented Feb 20, 2023

defined field names as part of #123

amorton added a commit that referenced this issue Feb 21, 2023
@amorton
Added limits for namespace, collection & docs
3335c48 
resolves #135
@amorton amorton self-assigned this Feb 21, 2023
@amorton
Copy link
Contributor Author

amorton commented Feb 21, 2023

Limits added in this commit 3335c48

@amorton
Copy link
Contributor Author

amorton commented Feb 21, 2023

@stargate/core-contributors I have added limits for docs etc in a commit in this ticket, I have not made an individual PR because it is hard to update a single document in multiple PR's. Please take a look if you are interested in these. Ticket #136 is waiting for the rules to be agreed.

amorton added a commit that referenced this issue Feb 22, 2023
@amorton
tweak doc limits from team meeting
6edc9b1 
resolves #135
@amorton amorton mentioned this issue Feb 22, 2023
Merged
2 tasks
This was referenced Feb 23, 2023
Closed
Closed
@amorton
Copy link
Contributor Author

amorton commented Feb 23, 2023

Created #172 and #173 to follow on

spec updated, and feature matrix updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amorton amorton

Labels
specifications Work needed on specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Spec changes for limits, options, field names and paths stargate/data-api
1 participant
@amorton