Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement document limits #173

Closed
amorton opened this issue Feb 23, 2023 · 3 comments · Fixed by #278
Closed

Implement document limits #173

amorton opened this issue Feb 23, 2023 · 3 comments · Fixed by #278
Assignees

Comments

@amorton
Copy link
Contributor

amorton commented Feb 23, 2023

Following from spec work in #135

Any document, on insert or after being updated, should be checked again the document rules.

Document limits are under the Documents section in the spec and include:

  • field name limits
  • and limits on the complexity and size of documents in Document Limits

If a document breaks any rule we should not store it.

If this is happening in an updateMany operation we should not store any of the updated documents.

Work may be blocked by deciding on rules for numbers in #172

@amorton
Copy link
Contributor Author

amorton commented Feb 23, 2023

@tatu-at-datastax assigning to you as I assume this is in shredding / de-shredding

@tatu-at-datastax
Copy link
Contributor

@amorton Yes makes sense was expecting to work on this. Will be interesting combination of validating at different stages, and happens to also align (surprisingly!) with some Jackson OSS work wrt limits -- which are mostly new additions in upcoming Jackson 2.15 (this is sort of hot topic right now; similar limits have existed in XML for a while, now coming to JSON processing).

@tatu-at-datastax
Copy link
Contributor

Fixed via #278 with the exception of Number limits, so #172 will remain open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants