refactor: fix moved to pascalToSnake

starknet-io · Aug 29, 2023 · 84aa539 · 84aa539
1 parent c871fe6
commit 84aa539
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/provider/rpc.ts b/src/provider/rpc.ts
@@ -457,12 +457,8 @@ export class RpcProvider implements ProviderInterface {
         txReceipt = await this.getTransactionReceipt(txHash);
 
         // TODO: Hotfix until Pathfinder release fixed casing
-        let executionStatus = txReceipt.execution_status;
-        let finalityStatus = txReceipt.finality_status;
-        if (/[a-z]/.test(txReceipt.execution_status)) {
-          executionStatus = pascalToSnake(txReceipt.execution_status);
-          finalityStatus = pascalToSnake(txReceipt.finality_status);
-        }
+        const executionStatus = pascalToSnake(txReceipt.execution_status);
+        const finalityStatus = pascalToSnake(txReceipt.finality_status);
 
         if (!executionStatus || !finalityStatus) {
           // Transaction is potentially REJECTED or NOT_RECEIVED but RPC doesn't have dose statuses

diff --git a/src/utils/encode.ts b/src/utils/encode.ts
@@ -80,7 +80,9 @@ export function utf8ToArray(str: string): Uint8Array {
  * @returns string
  */
 export const pascalToSnake = (text: string) =>
-  text
-    .split(/(?=[A-Z])/)
-    .join('_')
-    .toUpperCase();
+  !/[a-z]/.test(text)
+    ? text
+        .split(/(?=[A-Z])/)
+        .join('_')
+        .toUpperCase()
+    : text;