This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Hoist Python-to-Rust casts into bridge modules #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables greater versatility for upcoming pre and post-validation actions, orchestrated by PyValidator. As a nice, unrelated side effect, this purifies `TransactionExecutor` from direct `PyO3` dependencies, making it a pure Rust module.
Codecov Report
@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 51 51
Lines 6494 6494
Branches 6494 6494
=======================================
Hits 4374 4374
Misses 1737 1737
Partials 383 383
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables greater versatility for upcoming pre and post-validation actions, orchestrated by PyValidator.
As a nice, unrelated side effect, this purifies
TransactionExecutorfrom directPyO3dependencies, making it a pure Rust module.This change is