This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Raise an error when deploy account does not run in validate mode. #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 67.15% 67.20% +0.04%
==========================================
Files 52 52
Lines 6729 6739 +10
Branches 6729 6739 +10
==========================================
+ Hits 4519 4529 +10
+ Misses 1798 1797 -1
- Partials 412 413 +1 ☔ View full report in Codecov by Sentry. |
|
This PR is replaced by: #1156. |
ArniStarkware
deleted the
arni/starknet/execution_mode/deploy_account
branch
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
* core: upgradeable component wip * #[dojo::contract] merge Event, update upgradeable * update base_test.cairo & dojo-lang plugin_test_data * add Upgraded event in upgradeable component * move erc20, fix build issue, delete old tests * update erc20 to use #[dojo::contract] * revert changes on erc20 * revert changes on erc20 * fully qualify component * handle when Event is not defined in contract * follow clippy recomandation * torii: update records_contract address * trigger CI * trigger CI * rebase main * update manifest_test_data * use right records_contract address
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is