build: impl debug for felt (#198)

starkware-libs · Jun 6, 2024 · 618afae · 618afae
1 parent 83a3e89
commit 618afae
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/crates/committer/src/felt.rs b/crates/committer/src/felt.rs
@@ -1,3 +1,4 @@
+use core::fmt;
 use ethnum::U256;
 use serde::{Deserialize, Serialize};
 use starknet_types_core::felt::{Felt as StarknetTypesFelt, FromStrError};
@@ -7,7 +8,6 @@ use starknet_types_core::felt::{Felt as StarknetTypesFelt, FromStrError};
     PartialEq,
     Clone,
     Copy,
-    Debug,
     Default,
     Hash,
     derive_more::Add,
@@ -55,6 +55,12 @@ impl std::ops::Mul for Felt {
     }
 }
 
+impl fmt::Debug for Felt {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(f, "{:?}", U256::from(self))
+    }
+}
+
 impl Felt {
     pub const ZERO: Felt = Felt(StarknetTypesFelt::ZERO);
     #[allow(dead_code)]

diff --git a/crates/committer/src/patricia_merkle_tree/types_test.rs b/crates/committer/src/patricia_merkle_tree/types_test.rs
@@ -140,3 +140,9 @@ fn test_nodeindex_to_felt_conversion() {
     let index = NodeIndex::MAX;
     assert!(Felt::try_from(index).is_err());
 }
+
+#[rstest]
+fn test_felt_printing() {
+    let felt = Felt::from(17_u8);
+    assert_eq!(format!("{:?}", felt), "17");
+}
diff --git a/crates/committer_cli/src/parse_input/read_test.rs b/crates/committer_cli/src/parse_input/read_test.rs
@@ -341,7 +341,7 @@ fn test_input_parsing_with_mapping_key_duplicate() {
 
 "#;
     let expected_error =
-    "address to class hash: ContractAddress(Felt(Felt(FieldElement { value: UnsignedInteger { limbs: [72718179, 18446744073709551615, 6917529027641073992, 16140901064500135204] } })))";
+        "address to class hash: ContractAddress(6646139978924584093298644040422522880)";
     assert!(matches!(
         parse_input(input.to_string()).unwrap_err(),
         DeserializationError::KeyDuplicate(key) if key ==  expected_error