Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify compilation for other platfroms #11

Closed
wants to merge 4 commits into from

Conversation

Solpatium
Copy link
Contributor

@Solpatium Solpatium commented Jul 25, 2022

Please note that I am not a C++ expert, so I'll appreciate all feedback.
I included all changes necessary to get it working on my machine, but in the meantime some problems were fixed by other PRs. Starknet.py uses this code to build native code (https://github.com/software-mansion/starknet.py).

Changes:

COMMAND
${CMAKE_COMMAND} -E copy
${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.so
${CMAKE_CURRENT_SOURCE_DIR}/libcrypto_c_exports.so
${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To copy both .so and .dylib (mac) shared libs

@ilyalesokhin-starkware
Copy link
Collaborator

Please split this into multiple PRs.

  1. Portable-endian.h.
  2. .js changes
  3. boots 128bit.
  4. clang changes.

@Solpatium
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants