Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type of Verify function in ffi/ecdsa.cc #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bartekryba
Copy link

In ffi/ecdsa.h the interface of Verify method is as follows:

int Verify(const char* stark_key, const char* msg_hash, const char* r_bytes, const char* w_bytes);

but in ffi/ecdsa.cc it had a bool type.

The problem it caused:
I compiled crypto-cpp for Release (with -O3 flag), for ios and macos targets. On x86 macos target, calling Verify function would return very big numbers instead of 0 or 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant