Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add latency metrics, minor debug message change and mi… #2112

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

DvirYo-starkware
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware commented Jun 16, 2024

…nor fix


This change is Reviewable

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.34%. Comparing base (2c2218a) to head (2f96176).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   68.35%   68.34%   -0.01%     
==========================================
  Files         132      132              
  Lines       17585    17577       -8     
  Branches    17585    17577       -8     
==========================================
- Hits        12020    12013       -7     
  Misses       4234     4234              
+ Partials     1331     1330       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

@DvirYo-starkware DvirYo-starkware added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit dd3b492 Jun 17, 2024
49 checks passed
@DvirYo-starkware DvirYo-starkware deleted the dvir/debuging_fixes branch June 17, 2024 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants