Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabler returns CircleEvaluation #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaharsamocha7
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 commented Jan 21, 2025

This change is Reviewable

Copy link
Contributor Author

shaharsamocha7 commented Jan 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alon-f and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/components/utils.rs line 121 at r1 (raw file):

            col.set(i, M31::one());
        }
        CircleEvaluation::new(domain, col)

For uniformity with the other structs

Suggestion:

CircleEvaluation::new(CanonicCoset::new(self.log_size).circle_domain(), col)

Copy link

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare and @shaharsamocha7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants