Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros_bridge] Enable to use impedance controller through ros bridge with auto-generated idl python #533

Open
wants to merge 12 commits into
base: indigo-devel
Choose a base branch
from

Conversation

pazeshun
Copy link
Contributor

@pazeshun pazeshun commented Nov 22, 2018

Updated version of #527

What I did

  • Add auto-generation of ros bridge for old impedance controller inside HiroNX (generation of AbsoluteForceSensorServiceROSBridge and ImpedanceControllerServiceROSBridge)
    • Add idls for old impedance controller (AbsoluteForceSensorService.idl and ImpedanceControllerService.idl from [email protected])
    • Use rtmbuild and custom cmake macro to generate and build ros bridge executables from idls
  • Add auto-generation of hironx_ros_bridge/src/hironx_ros_bridge/hrpsys_315_1_9/hrpsys/*_idl.py based on rtmbuild Add auto-generation of *_idl.py in <WS NAME>/devel/lib/python2.7/dist-packages/hironx_ros_bridge/idl_315_1_9 based on rtmbuild
    • Remove original hironx_ros_bridge/src/hironx_ros_bridge/hrpsys_315_1_9/hrpsys/*_idl.py
  • Fix ros bridge launch to run generated ros bridge executables instead of ones in hrpsys_ros_bridge
    • Because ros bridge executables in hrpsys_ros_bridge are generated from idls in latest hrpsys-base, which don't have AbsoluteForceSensorService.idl and have different ImpedanceControllerService.idl

@pazeshun pazeshun changed the title [ros_bridge] Enable to use impedance controller through ros bridge with python [ros_bridge] Enable to use impedance controller through ros bridge with auto-generated idl python Nov 22, 2018
@pazeshun
Copy link
Contributor Author

pazeshun commented Nov 23, 2018

TODOs to refine

  • Create directory idl_315_1_9 under lib/python2.7/dist-packages/hironx_ros_bridge and move idl python there (@ cdd9b65)
  • Add version suffix to ...
    • C++ files in src_gen (AbsoluteForceSensorServiceROSBridge.cpp, AbsoluteForceSensorServiceROSBridge.h, AbsoluteForceSensorServiceROSBridgeComp.cpp, ...)
    • Executable of *Comp (AbsoluteForceSensorServiceROSBridgeComp and ImpedanceControllerServiceROSBridgeComp)
    • ROS messages and services in msg and srv (OpenHRP_AbsoluteForceSensorService.msg ...)
  • Follow check hrpsys/rtmros from sources rtmros_common#1068

@pazeshun pazeshun force-pushed the impedance-thru-ros-bridge-general branch from 479fd68 to ca735a1 Compare April 18, 2019 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant