Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INI: Add support for new windows 10.0.17763.437 (1809) & 10.0.17134.706 (1803) #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

INI: Add support for new windows 10.0.17763.437 (1809) & 10.0.17134.706 (1803) #782

wants to merge 1 commit into from

Conversation

christian-elias
Copy link

@davext
Copy link

davext commented May 31, 2019

Works under

OS Name             : Microsoft Windows 10 Home
OS Version          : 10.0.17134 N/A Build 17134
OS Manufacturer     : Microsoft Corporation
OS Configuration    : Standalone Workstation
OS Build Type       : Multiprocessor Free
System Boot Time    : 5/29/2019, 10:29:40 PM
System Manufacturer : Dell Inc.
System Model        : XPS 8700
System Type         : x64-based PC
System Directory    : C:\WINDOWS\system32
System Locale       : en-us;English (United States)
Hotfix(s)           : 14 Hotfix(s) Installed.,[01]: KB4100347,[02]: KB4343669,[03]: KB4456655,[04]: KB4465663,[05]:
                      KB4471331,[06]: KB4477137,[07]: KB4480979,[08]: KB4485449,[09]: KB4487038,[10]: KB4489907,[11]:
                      KB4493478,[12]: KB4497398,[13]: KB4497932,[14]: KB4499167

@stiltr
Copy link

stiltr commented May 31, 2019

Works under

OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.17134 N/A Build 17134
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
System Boot Time:          5/20/2019, 5:35:36 PM
System Manufacturer:       HP
System Model:              HP EliteDesk 705 G4 SFF
System Type:               x64-based PC
System Directory:          C:\windows\system32
System Locale:             en-us;English (United States)
Hotfix(s):                 7 Hotfix(s) Installed.
                           [01]: KB4100347
                           [02]: KB4477137
                           [03]: KB4485449
                           [04]: KB4493478
                           [05]: KB4497398
                           [06]: KB4497932
                           [07]: KB4499167

zhangyoufu
zhangyoufu reviewed Jun 9, 2019
View reviewed changes
res/rdpwrap.ini
LocalOnlyOffset.x64=77A41
LocalOnlyCode.x64=jmpshort
SingleUserPatch.x64=1
SingleUserOffset.x64=3E520
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have duplicate sections of [10.0.17763.437]?

SingleUserOffset.x64=3E520 is incorrect for 10.0.17763.437

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is SingleUserOffset.x64=1322C correct for 10.0.17763.437?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRSDavidSoft DRSDavidSoft DRSDavidSoft left review comments

@zhangyoufu zhangyoufu zhangyoufu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christian-elias @davext @stiltr @zhangyoufu @DRSDavidSoft