Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make builds deterministic and reproducible #246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

7dJx1qP
Copy link
Contributor

@7dJx1qP 7dJx1qP commented Feb 10, 2024

The current build_site.sh script generates a new hash for every deployment even if the plugin hasn't changed. The reason the hashes change is due to file timestamps changing when the build checks out the repo and file order when creating the zip.

To address this, I've updated the script so that it sets each file timestamp to the updated date that's already being used and sorts the files that it zips. I also added sorting of the plugins and themes in the index.yml

@Tetrax-10
Copy link
Collaborator

After this PR #244 this repo no more uses the build_site.sh to build the plugins instead a nodejs based build.js, so we can build normal plugins and stash-plugin-builder plugins, you can implement this feature here as build.jsalso uses zip sh under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants