Add Scene Page Remember States plugin #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DogmaDragon
reviewed
Jun 19, 2024
| version: 0.1 | ||
| ui: | ||
| requires: | ||
| - stashUserscriptLibrary |
There was a problem hiding this comment.
stashUserscriptLibrary is no longer part of the CommunityScripts repository. It was replaced with https://github.com/stashapp/CommunityScripts/tree/main/plugins/CommunityScriptsUILibrary, but it might be lacking some functionality.
Needs a review.
feederbox826
requested changes
Jun 23, 2024
| function main() { | ||
| nav(), handlePageDivider(); | ||
| } | ||
| stash.addEventListener("stash:page:scene", main()); |
There was a problem hiding this comment.
replaced by PathElementListener
csLib.PathElementListener("/scene/", "", main))| @@ -0,0 +1,101 @@ | |||
| (async function waitForStash() { | |||
| while (!window.stash) { | |||
There was a problem hiding this comment.
window.stash is never exposed and being a requirement should ensure it's loaded beforehand
| } | ||
|
|
||
| function handlePageDivider() { | ||
| waitForElementClass("scene-tabs order-xl-first order-last", function () { |
There was a problem hiding this comment.
see other waitForElement comment
| } | ||
|
|
||
| function nav() { | ||
| waitForElementClass("mr-auto nav nav-tabs", function () { |
There was a problem hiding this comment.
waitForElement(".mr-auto.nav.nav-tabs", function() {| { name: "Edit", key: "scene-edit-panel" }, | ||
| ]; | ||
|
|
||
| const detailsNav = document.getElementsByClassName( |
There was a problem hiding this comment.
see other WaitForElement comment
| const detailsNav = document.getElementsByClassName( | ||
| "mr-auto nav nav-tabs" | ||
| )[0]; | ||
| const hrefs = detailsNav.getElementsByTagName("a"); |
There was a problem hiding this comment.
see other waitForElement comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin uses local storage in the browser, to remember last active nav tab of the scenes' detail panel and upon page load activate it, so it's the current panel shown.
It also remembers the active state of the divider collapse button and if true on page load will simulate a click to collapse, so the scene player takes up the full width of the page.