Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ES v8.2.0 dashboard backup and restore #1459

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

ishtiaqhimel
Copy link
Member

No description provided.

Copy link

gitguardian bot commented Jan 25, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
334687 Generic High Entropy Secret 964fa06 vendor/github.com/go-resty/resty/v2/request.go View secret
334687 Generic High Entropy Secret 964fa06 vendor/github.com/go-resty/resty/v2/client.go View secret
334688 Generic High Entropy Secret 964fa06 vendor/github.com/go-resty/resty/v2/client.go View secret
334688 Generic High Entropy Secret 964fa06 vendor/github.com/go-resty/resty/v2/request.go View secret
8948416 Company Email Password 964fa06 vendor/github.com/go-resty/resty/v2/request.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raihankhan raihankhan changed the title Add elastic dashboard backup and restore support Add Support for ES v8.2.0 dashboard backup and restore Feb 2, 2024
@raihankhan raihankhan added the automerge Kodiak will auto merge PRs that have this label label Feb 2, 2024
@kodiakhq kodiakhq bot merged commit 24ecc28 into release-8.2.0 Feb 2, 2024
5 checks passed
@kodiakhq kodiakhq bot deleted the r8.2.0 branch February 2, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Kodiak will auto merge PRs that have this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants