-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Roll back CronJob API to batch/v1beta1 (#1429)
Signed-off-by: Emruz Hossain <[email protected]>
- Loading branch information
Showing
5 changed files
with
136 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| Copyright AppsCode Inc. and Contributors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1beta1 | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/pkg/errors" | ||
| batch "k8s.io/api/batch/v1beta1" | ||
| kerr "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/apimachinery/pkg/util/strategicpatch" | ||
| "k8s.io/apimachinery/pkg/util/wait" | ||
| "k8s.io/client-go/kubernetes" | ||
| "k8s.io/klog/v2" | ||
| kutil "kmodules.xyz/client-go" | ||
| ) | ||
|
|
||
| func CreateOrPatchCronJob(ctx context.Context, c kubernetes.Interface, meta metav1.ObjectMeta, transform func(*batch.CronJob) *batch.CronJob, opts metav1.PatchOptions) (*batch.CronJob, kutil.VerbType, error) { | ||
| cur, err := c.BatchV1beta1().CronJobs(meta.Namespace).Get(ctx, meta.Name, metav1.GetOptions{}) | ||
| if kerr.IsNotFound(err) { | ||
| klog.V(3).Infof("Creating CronJob %s/%s.", meta.Namespace, meta.Name) | ||
| out, err := c.BatchV1beta1().CronJobs(meta.Namespace).Create(ctx, transform(&batch.CronJob{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: "CronJob", | ||
| APIVersion: batch.SchemeGroupVersion.String(), | ||
| }, | ||
| ObjectMeta: meta, | ||
| }), metav1.CreateOptions{ | ||
| DryRun: opts.DryRun, | ||
| FieldManager: opts.FieldManager, | ||
| }) | ||
| return out, kutil.VerbCreated, err | ||
| } else if err != nil { | ||
| return nil, kutil.VerbUnchanged, err | ||
| } | ||
| return PatchCronJob(ctx, c, cur, transform, opts) | ||
| } | ||
|
|
||
| func PatchCronJob(ctx context.Context, c kubernetes.Interface, cur *batch.CronJob, transform func(*batch.CronJob) *batch.CronJob, opts metav1.PatchOptions) (*batch.CronJob, kutil.VerbType, error) { | ||
| return PatchCronJobObject(ctx, c, cur, transform(cur.DeepCopy()), opts) | ||
| } | ||
|
|
||
| func PatchCronJobObject(ctx context.Context, c kubernetes.Interface, cur, mod *batch.CronJob, opts metav1.PatchOptions) (*batch.CronJob, kutil.VerbType, error) { | ||
| curJson, err := json.Marshal(cur) | ||
| if err != nil { | ||
| return nil, kutil.VerbUnchanged, err | ||
| } | ||
|
|
||
| modJson, err := json.Marshal(mod) | ||
| if err != nil { | ||
| return nil, kutil.VerbUnchanged, err | ||
| } | ||
|
|
||
| patch, err := strategicpatch.CreateTwoWayMergePatch(curJson, modJson, batch.CronJob{}) | ||
| if err != nil { | ||
| return nil, kutil.VerbUnchanged, err | ||
| } | ||
| if len(patch) == 0 || string(patch) == "{}" { | ||
| return cur, kutil.VerbUnchanged, nil | ||
| } | ||
| klog.V(3).Infof("Patching CronJob %s/%s with %s.", cur.Namespace, cur.Name, string(patch)) | ||
| out, err := c.BatchV1beta1().CronJobs(cur.Namespace).Patch(ctx, cur.Name, types.StrategicMergePatchType, patch, opts) | ||
| return out, kutil.VerbPatched, err | ||
| } | ||
|
|
||
| func TryUpdateCronJob(ctx context.Context, c kubernetes.Interface, meta metav1.ObjectMeta, transform func(*batch.CronJob) *batch.CronJob, opts metav1.UpdateOptions) (result *batch.CronJob, err error) { | ||
| attempt := 0 | ||
| err = wait.PollImmediate(kutil.RetryInterval, kutil.RetryTimeout, func() (bool, error) { | ||
| attempt++ | ||
| cur, e2 := c.BatchV1beta1().CronJobs(meta.Namespace).Get(ctx, meta.Name, metav1.GetOptions{}) | ||
| if kerr.IsNotFound(e2) { | ||
| return false, e2 | ||
| } else if e2 == nil { | ||
| result, e2 = c.BatchV1beta1().CronJobs(cur.Namespace).Update(ctx, transform(cur.DeepCopy()), opts) | ||
| return e2 == nil, nil | ||
| } | ||
| klog.Errorf("Attempt %d failed to update CronJob %s/%s due to %v.", attempt, cur.Namespace, cur.Name, e2) | ||
| return false, nil | ||
| }) | ||
|
|
||
| if err != nil { | ||
| err = errors.Errorf("failed to update CronJob %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err) | ||
| } | ||
| return | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| Copyright AppsCode Inc. and Contributors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1beta1 | ||
|
|
||
| import ( | ||
| jsoniter "github.com/json-iterator/go" | ||
| ) | ||
|
|
||
| var json = jsoniter.ConfigFastest |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters