Add payment channel updated stream to ts rpc client #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation appears to inherit the tsdoc (it shows up in intellisense in my editor)
don't try and convert undefined to a bigint
👷 Deploy Preview for nitrodocs processing.
|
bitwiseguy
approved these changes
Oct 5, 2023
|
@bitwiseguy any opinion on this
|
Sorry @geoknee I think I am missing some context. What exactly are you proposing that we name |
geoknee
commented
Oct 5, 2023
Comment on lines
108
to
116
| /** | ||
| * PaymentChannelUpdated attaches a callback which is triggered when the channel with supplied ID is updated. | ||
| * | ||
| * @param objectiveId - The id objective to wait for | ||
| */ | ||
| PaymentChannelUpdated( | ||
| channelId: string, | ||
| callback: (info: PaymentChannelInfo) => void | ||
| ): Promise<void>; |
There was a problem hiding this comment.
Here's what I am wondering about the naming of.
Thinking about the usage, which of the following makes the most sense
nitroClient.PaymentChannelUpdated("0xabc",()=>{dothing()})
nitroClient.onPaymentChannelUpdated("0xabc",()=>{dothing()})
There was a problem hiding this comment.
Ok I got it. I don't have strong preference, but lean towards:
nitroClient.onPaymentChannelUpdate("0xabc",()=>{dothing()})and return cleanup fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1770
There is very little in the way of unit or integration tests setup at present. Therefore I have filed #1806, and we should make sure to cover this event stream in that work.