Fix data races #694
Merged
Fix data races #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wtf, how did this merge go bad |
|
sourishkrout
added a commit
that referenced
this pull request
Nov 5, 2024
This reverts commit 002fb9f.
|
@adambabik I'm puzzled about what went wrong when I used GitHub's Could you please take a look? I can't get the docker tests to pass at all. I suspect some of your changes got lost? |
Merged
|
@sourishkrout yeah, something went off. I didn't dig into that, but I created a new branch and rebased instead. I also dug a bit more into flaky tests in Docker and updated a couple. Let's review #697 and try to merge again. |
sourishkrout
pushed a commit
that referenced
this pull request
Nov 8, 2024
This PR adds `go vet` call, including [`checklocks`](https://pkg.go.dev/gvisor.dev/gvisor/tools/checklocks), in `make lint`. It also fixes data races found using `RACE=true make test/execute`. Retrying reverted #694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
go vetcall, includingchecklocks, inmake lint. It also fixes data races found usingRACE=true make test/execute.