Update PheWeb for changes in LZjs 0.14.0 #185
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦑 Hold for final release of LZ 0.14.0
Purpose
The next release of LocusZoom makes breaking changes to how data is retrieved. This PR updates PheWeb to work with the new version, and introduces small user-facing benefits in terms of larger font sizes and a more concise legend for association plots. This will help people to use figures from PheWeb in publications or presentations.
Blockers
Hold for the final release of LocusZoom.js 14, so that we can update the version string in this PR before merge. (I'm hoping that will happen soon)
Testing notes
log_pvalue
(instead of just pvalue). It seems silly to duplicate, and this could be fragile in cases of numerical underflow. Is there a pheweb branch that uses log pvalue internally?