20/isin array #34
Open
20/isin array #34
+866
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors in AK_isin_array_dtype
…ranch I forgot about.
brandtbucher
requested changes
Mar 15, 2021
There was a problem hiding this comment.
Oh boy. 🙂
I just went over this quickly during lunch. I've refrained from checking or commenting on anything except refcounts, to keep this focused.
I may have missed or falsely flagged some since I went through this so quickly. But I'm confident most of them are genuine leaks.
|
Thanks @brandtbucher . These comments make me realize that my understanding of Python's object reference management is virtually non-existent. I'm thinking that it would be really helpful to meet with you to talk about it since I want to understand the core design of it, so that I can intuit where (and why) these leaks are happening myself |
Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Checklist