-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build inside a builder container #84
Conversation
Yes! ❤️ Can you remove the maven build from outside the Docker-build? |
Done. Although I'm still on thin ice when it comes to GitHub actions, so not sure it is correct. |
We should also probably test changing |
I tested locally, first changing the pom and then a source file. The results were as we hope for. But I'm only using |
The GH Docker cache setup is quite aggressive, but this seems to work as we want. |
There are commits for "change pom" and "change source file" that probably have some action runs. Looks fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's try this for some time!
Something like this, @erikgb? We will, of course, need to ditch anything maven from the actions if we select to go this way.