Skip to content

Commit

Permalink
chore: migrate to use BOMs for dependency management (#38)
Browse files Browse the repository at this point in the history
  • Loading branch information
erikgb authored Mar 17, 2024
1 parent 076b075 commit e64a4d2
Showing 1 changed file with 30 additions and 12 deletions.
42 changes: 30 additions & 12 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,37 @@
<maven-surefire.version>3.2.5</maven-surefire.version>
</properties>

<dependencies>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.10.2</version>
<type>pom</type>
<scope>import</scope>
</dependency>

<!-- Must manage Jackson dependencies to avoid conflicts with Scala -->
<dependency>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>2.17.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>

<!-- Must manage dependency since kafka-clients currently depends on slf4j 1.x -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-bom</artifactId>
<version>2.0.12</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
Expand All @@ -49,18 +78,9 @@
<scope>provided</scope>
</dependency>

<!-- Required by Apache version of kafka-clients -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.17.0</version>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-jdk14</artifactId>
<version>1.7.36</version>
<scope>test</scope>
</dependency>

Expand Down Expand Up @@ -88,10 +108,8 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>5.10.2</version>
<scope>test</scope>
</dependency>

</dependencies>

<build>
Expand Down

0 comments on commit e64a4d2

Please sign in to comment.