lint

statsig-io · Sep 13, 2023 · 1206826 · 1206826
1 parent d421b69
commit 1206826
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 25 deletions.
diff --git a/src/main/java/com/statsig/androidsdk/HttpUtils.kt b/src/main/java/com/statsig/androidsdk/HttpUtils.kt
@@ -7,7 +7,6 @@ import okhttp3.Response
 import okhttp3.ResponseBody.Companion.toResponseBody
 import java.net.HttpURLConnection
 
-
 private val RETRY_CODES: IntArray = intArrayOf(
     HttpURLConnection.HTTP_CLIENT_TIMEOUT,
     HttpURLConnection.HTTP_INTERNAL_ERROR,
@@ -26,7 +25,7 @@ private const val STATSIG_SDK_TYPE_KEY = "STATSIG-SDK-TYPE"
 private const val STATSIG_SDK_VERSION_KEY = "STATSIG-SDK-VERSION"
 private const val ACCEPT_HEADER_KEY = "Accept"
 private const val ACCEPT_HEADER_VALUE = "application/json"
-internal val JSON: MediaType = "application/json; charset=utf-8".toMediaType();
+internal val JSON: MediaType = "application/json; charset=utf-8".toMediaType()
 
 class RequestHeaderInterceptor(private val sdkKey: String) : Interceptor {
     @Throws(Exception::class)
@@ -70,4 +69,4 @@ class ResponseInterceptor : Interceptor {
             .addHeader("attempt", attempt.toString())
             .build()
     }
-}
+}
diff --git a/src/main/java/com/statsig/androidsdk/InitializeResponse.kt b/src/main/java/com/statsig/androidsdk/InitializeResponse.kt
@@ -1,10 +1,7 @@
 package com.statsig.androidsdk
 
-import com.google.gson.JsonObject
-import com.google.gson.JsonSerializer
 import com.google.gson.annotations.SerializedName
 
-
 enum class InitializeFailReason {
     CoroutineTimeout,
     NetworkTimeout,
@@ -35,7 +32,7 @@ internal data class APIFeatureGate(
     @SerializedName("secondary_exposures") val secondaryExposures: Array<Map<String, String>> = arrayOf(),
 )
 
-internal data class APIDynamicConfig (
+internal data class APIDynamicConfig(
     @SerializedName("name") val name: String,
     @SerializedName("value") val value: Map<String, Any>,
     @SerializedName("rule_id") val ruleID: String?,

diff --git a/src/main/java/com/statsig/androidsdk/StatsigClient.kt b/src/main/java/com/statsig/androidsdk/StatsigClient.kt
@@ -44,6 +44,7 @@ internal class StatsigClient() {
 
     @VisibleForTesting
     internal lateinit var statsigNetwork: StatsigNetwork
+
     @VisibleForTesting
     internal lateinit var options: StatsigOptions
 

diff --git a/src/main/java/com/statsig/androidsdk/StatsigNetwork.kt b/src/main/java/com/statsig/androidsdk/StatsigNetwork.kt
@@ -16,7 +16,6 @@ import java.net.ConnectException
 import java.net.SocketTimeoutException
 import java.util.concurrent.TimeUnit
 
-
 // Constants
 private val MAX_LOG_PERIOD = TimeUnit.DAYS.toMillis(3)
 private const val POLLING_INTERVAL_MS: Long = 10000
@@ -213,8 +212,13 @@ internal class StatsigNetwork(
                 }
                 var response = client.newCall(request).execute()
                 var code = response.code
-                endDiagnostics(diagnostics, contextType, code,
-                    response.headers["x-statsig-region"], response.headers["attempt"]?.toInt())
+                endDiagnostics(
+                    diagnostics,
+                    contextType,
+                    code,
+                    response.headers["x-statsig-region"],
+                    response.headers["attempt"]?.toInt(),
+                )
                 when (code) {
                     in 200..299 -> {
                         if (code == 204 && endpoint == INITIALIZE_ENDPOINT) {

diff --git a/src/test/java/com/statsig/androidsdk/AsyncInitVsUpdateTest.kt b/src/test/java/com/statsig/androidsdk/AsyncInitVsUpdateTest.kt
@@ -6,7 +6,6 @@ import io.mockk.coEvery
 import io.mockk.mockk
 import io.mockk.spyk
 import kotlinx.coroutines.*
-import okhttp3.mockwebserver.MockWebServer
 import org.junit.Assert.assertEquals
 import org.junit.Before
 import org.junit.Test

diff --git a/src/test/java/com/statsig/androidsdk/ErrorBoundaryTest.kt b/src/test/java/com/statsig/androidsdk/ErrorBoundaryTest.kt
@@ -102,7 +102,7 @@ class ErrorBoundaryTest {
                     app,
                     "client-key",
                     null,
-                    options = StatsigOptions(disableDiagnosticsLogging = true)
+                    options = StatsigOptions(disableDiagnosticsLogging = true),
                 )
                 Statsig.shutdown()
             }
@@ -132,7 +132,7 @@ class ErrorBoundaryTest {
                     app,
                     "client-key",
                     null,
-                    options = StatsigOptions(disableDiagnosticsLogging = true)
+                    options = StatsigOptions(disableDiagnosticsLogging = true),
                 )
                 Statsig.shutdown()
             }

diff --git a/src/test/java/com/statsig/androidsdk/LayerExposureTest.kt b/src/test/java/com/statsig/androidsdk/LayerExposureTest.kt
@@ -316,7 +316,7 @@ class LayerExposureTest {
                 // filter out diagnostics data
                 val events = result.events.filter { event -> event.eventName != "statsig::diagnostics" }
                 logs = if (events.isEmpty())null else LogEventData(events as ArrayList<LogEvent>, result.statsigMetadata)
-            }
+            },
         )
         initTime = System.currentTimeMillis()
         TestUtil.startStatsigAndWait(app, user = user, server = server)

diff --git a/src/test/java/com/statsig/androidsdk/StatsigTest.kt b/src/test/java/com/statsig/androidsdk/StatsigTest.kt
@@ -2,7 +2,6 @@ package com.statsig.androidsdk
 
 import android.app.Application
 import com.google.gson.Gson
-import io.mockk.coEvery
 import io.mockk.mockk
 import io.mockk.unmockkAll
 import kotlinx.coroutines.runBlocking

diff --git a/src/test/java/com/statsig/androidsdk/StoreTest.kt b/src/test/java/com/statsig/androidsdk/StoreTest.kt
@@ -1,7 +1,6 @@
 package com.statsig.androidsdk
 
 import android.app.Application
-import io.mockk.coVerify
 import io.mockk.every
 import io.mockk.mockk
 import io.mockk.mockkObject

diff --git a/src/test/java/com/statsig/androidsdk/TestUtil.kt b/src/test/java/com/statsig/androidsdk/TestUtil.kt
@@ -10,12 +10,7 @@ import com.google.gson.JsonObject
 import com.google.gson.JsonPrimitive
 import com.google.gson.JsonSerializationContext
 import com.google.gson.JsonSerializer
-import com.google.gson.TypeAdapter
-import com.google.gson.TypeAdapterFactory
-import com.google.gson.annotations.SerializedName
 import com.google.gson.reflect.TypeToken
-import com.google.gson.stream.JsonReader
-import com.google.gson.stream.JsonWriter
 import io.mockk.*
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.ExperimentalCoroutinesApi
@@ -31,7 +26,6 @@ import java.lang.reflect.Type
 import java.util.concurrent.CountDownLatch
 import java.util.concurrent.TimeUnit
 
-
 @OptIn(ExperimentalCoroutinesApi::class)
 class TestUtil {
     companion object {
@@ -325,7 +319,7 @@ class TestUtil {
             time: Long? = null,
             hasUpdates: Boolean = true,
             onLog: ((LogEventData) -> Unit)? = null,
-            getInitializeResponse: ((InitializeRequestBody) -> InitializeResponse)? = null
+            getInitializeResponse: ((InitializeRequestBody) -> InitializeResponse)? = null,
         ): MockWebServer {
             var server = MockWebServer()
             server.apply {
@@ -341,7 +335,7 @@ class TestUtil {
                                 }
                                 val type = object : TypeToken<MutableMap<String, Any>>() {}.type
                                 val gson = GsonBuilder().registerTypeAdapter(
-                                    type, PolymorphicSerializer()
+                                    type, PolymorphicSerializer(),
                                 ).create()
                                 var stringified = gson.toJson(response)
                                 return MockResponse().setResponseCode(200).setBody(stringified)
@@ -380,7 +374,7 @@ class TestUtil {
             override fun serialize(
                 src: Any?,
                 typeOfSrc: Type?,
-                context: JsonSerializationContext?
+                context: JsonSerializationContext?,
             ): JsonElement {
                 return src.let {
                     if (it is Map<*, *>) {