update images in export pulse data #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| | experiment_group | The group the user was assigned to | | ||
| | first_exposure_utc | The UTC timestamp when the user was first assigned to the experiment | | ||
| | first_exposure_pst_date | The date in PST when the user was first assigned to the experiment | | ||
| | as_of_pst_date | The date this data was generated | |
There was a problem hiding this comment.
The as_of_pst_date column has extra whitespace in its description cell that breaks the table's alignment. Consider removing the extra spaces to maintain consistent formatting with other rows.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| | Column Name | Description | | ||
| | ---------------- | ------------------------------------------------------------------------------------------- | | ||
| | pst_ds | The 24hr window the the data refers to. All dates are anchored from 12:00a -> 11:59p PST. | |
There was a problem hiding this comment.
There appears to be a duplicate "the" in the description text. The text should read: "The 24hr window the data refers to" instead of "The 24hr window the the data refers to"
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
liz-statsig
force-pushed
the
12-17-update_images_in_export_pulse_data
branch
from
1da740e to
ccc51b1
Compare
liz-statsig
force-pushed
the
12-17-update_images_in_export_pulse_data
branch
from
ccc51b1 to
965f447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update images for the "how to export pulse data" doc - the previous images are a few years out of date
Other lines with "changes" are just code formatting and shouldn't change anything