fix: #43 appVersion is unknown in case Assembly.GetEntryAssembly() is…

…… (#149) … not set Merging in public PR: #44 --------- Co-authored-by: ondrej.pajgrt <[email protected]>
statsig-io · Jun 26, 2024 · 497d318 · 497d318
1 parent 053c3e8
commit 497d318
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -8,21 +8,24 @@ on:
 
 jobs:
   build:
+    timeout-minutes: 10
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v2
+
       - name: Setup .NET Core SDK
         uses: actions/setup-dotnet@v2
         with:
           dotnet-version: "6.x.x"
+
       - name: Install dependencies
         run: dotnet restore
+
       - name: Build
         run: dotnet build --configuration Release --no-restore
-        timeout-minutes: 3
+
       - name: Test
         run: dotnet test --no-restore --verbosity normal
-        timeout-minutes: 5
         env:
           test_api_key: ${{ secrets.SDK_CONSISTENCY_TEST_COMPANY_API_KEY }}
           test_client_key: ${{ secrets.SDK_CLIENT_KEY }}
diff --git a/dotnet-statsig/src/Statsig/Client/ClientDriver.cs b/dotnet-statsig/src/Statsig/Client/ClientDriver.cs
@@ -406,7 +406,7 @@ IReadOnlyDictionary<string, string> GetStatsigMetadata()
                     ["sessionID"] = _sessionID,
                     ["stableID"] = PersistentStore.StableID,
                     ["locale"] = CultureInfo.CurrentUICulture.Name,
-                    ["appVersion"] = Assembly.GetEntryAssembly()!.GetName()!.Version!.ToString()!,
+                    ["appVersion"] = Assembly.GetEntryAssembly()?.GetName().Version!.ToString() ?? "unknown",
                     ["systemVersion"] = Environment.OSVersion.Version.ToString(),
                     ["systemName"] = systemName,
                     ["sdkType"] = sdkDetails.SDKType,