feat: bootstrap and timeout initialization #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
reviewed
Dec 17, 2024
| end | ||
| end | ||
|
|
||
| defp update_specs(specs) do |
There was a problem hiding this comment.
i would expect this to return the updated configs and not just the time, which doesn't seem to be added to the configs that have been updated.
| update_specs(response) | ||
| {:ok, %{state | last_sync_time: new_time}} | ||
| rescue | ||
| error -> |
There was a problem hiding this comment.
what can happen to cause this? It's a little strange to see a try/rescue in elixir code.
I would actually make it so that update_specs can't raise.
| @@ -41,9 +47,12 @@ defmodule Statsig.Configs do | |||
| @impl true | |||
| def init(_) do | |||
| :ets.new(@table_name, [:named_table, :set, :public]) | |||
| initial_state = State.new() | |||
| initial_state = case init_from_bootstrap() do | |||
There was a problem hiding this comment.
nit: this looks like it wasn't formatted.
Comment on lines
+22
to
+23
| interval = reload_interval() | ||
| %__MODULE__{reload_interval: interval} |
| end | ||
|
|
||
| test "uses bootstrapped gate values" do | ||
| {:ok, result} = Statsig.check_gate(%Statsig.User{user_id: "12345"}, "test_numeric_user_id") |
There was a problem hiding this comment.
for gates, there's a three way logic here that I'm not sure you intended.
One option is some kind of error occurring, the other is that the result is true or false.
Can you describe how checking a gate can fail? As a user, I'd prefer:
if Statsig.check_gate?(...) do
...
end| @@ -41,9 +47,12 @@ defmodule Statsig.Configs do | |||
| @impl true | |||
| def init(_) do | |||
| :ets.new(@table_name, [:named_table, :set, :public]) | |||
| initial_state = State.new() | |||
| initial_state = case init_from_bootstrap() do | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main pieces missing to initialization to make this more robust. We dont want to block application startup because of a) a network request taking too long or b) failure to initialize statsig.
This adds two configuration options:
To address this. Bootstrapping will still attempt to sync from the network