Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow configuring topics explicitly #9

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

jm-clius
Copy link
Contributor

Allows topics subscription to be configured for nodes.

Only aimed at the wakuv2.* fleets and not status.* fleets, which can remain subscribed only to the default pubsub topic.

Related to: waku-org/pm#13

Corresponding PR in infra-nim-waku to follow.

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things that are lists should be lists.

defaults/main.yml Outdated Show resolved Hide resolved
templates/docker-compose.yml.j2 Outdated Show resolved Hide resolved
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Update defaults/main.yml

Co-authored-by: Jakub <[email protected]>

Update templates/docker-compose.yml.j2

Co-authored-by: Jakub <[email protected]>

fix: add quotes around flag
@jm-clius jm-clius requested a review from jakubgs February 14, 2023 15:38
@jakubgs jakubgs merged commit af90c66 into master Feb 14, 2023
@jakubgs jakubgs deleted the chore/topic-config branch February 14, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants