fix stylecheck for UInt256 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
Araq
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Oct 11, 2024
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99
narimiran
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Oct 11, 2024
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99 (cherry picked from commit aaf6c40)
metagn
added a commit
to metagn/nim-json-rpc
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in nim-lang/Nim#24269, stylecheck has a bug where it doesn't check the usage of symbols from other packages. The tests for this library enable --styleCheck:error, so the style for symbols from other packages is fixed. In this library the only mismatching usage seems to be
UInt256.