Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styleCheck tweaks #6638

Merged
merged 1 commit into from
Oct 11, 2024
Merged

styleCheck tweaks #6638

merged 1 commit into from
Oct 11, 2024

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Oct 11, 2024

version-2-0 today got a fix for --styleCheck:error not having worked since Nim 1.6.12, which has started triggering on

2024-10-11T13:44:53.8027919Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/helpers.nim(323, 43) Error: 'None' should be: 'NONE' [enumField declared in /github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-chronicles/chronicles/options.nim(40, 5)]

in several ncli/ and research/ modules.

@tersec tersec enabled auto-merge (squash) October 11, 2024 20:42
@github-actions GitHub Actions
Copy link

Unit Test Results

       12 files  ±0    1 810 suites  ±0   54m 35s ⏱️ - 1m 10s
  5 227 tests ±0    4 879 ✔️ ±0  348 💤 ±0  0 ❌ ±0 
29 057 runs  ±0  28 605 ✔️ ±0  452 💤 ±0  0 ❌ ±0 

Results for commit 3806a8d. ± Comparison against base commit 5608a80.

@tersec tersec merged commit bc51ba3 into unstable Oct 11, 2024
13 checks passed
@tersec tersec deleted the FEI branch October 11, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tersec