Add new member after typing message and pressing enter #17014
+23
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (7)
|
jrainville
force-pushed
the
feat/group-chat-add-member-improvement
branch
from
0487ddc to
3fb89d6
Compare
caybro
reviewed
Jan 2, 2025
| @@ -291,6 +292,12 @@ StatusSectionLayout { | |||
| amISectionAdmin: root.amISectionAdmin | |||
| sendViaPersonalChatEnabled: root.sendViaPersonalChatEnabled | |||
| paymentRequestFeatureEnabled: root.paymentRequestFeatureEnabled | |||
| selectingMembers: headerContentLoader.item && !!headerContentLoader.item.selectingMembers | |||
| onGroupUpdated: { | |||
| if (headerContentLoader.item && headerContentLoader.item instanceof ChatHeaderContentView) { | |||
There was a problem hiding this comment.
This seems somewhat odd... to rely on the concrete underlying type of the component; but I don't really have a better idea atm 🤷
There was a problem hiding this comment.
Yeah, it was either that or doing !!headerContentLoader.item.groupUpdated. It's as you prefer
Fixes #8349 When the member selector menu is open, sending a message adds/removes the members and then sends the message. Therefore, the new member will also receive the message.
jrainville
force-pushed
the
feat/group-chat-add-member-improvement
branch
from
3fb89d6 to
0702919
Compare
|
@alexjba @micieslak friendly reminder to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #8349
When the member selector menu is open, sending a message adds/removes the members and then sends the message. Therefore, the new member will also receive the message.
The first commit is just a cleanup of code taht is never used
Affected areas
Group chat member selection (for existing chat)
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
add-remove-members.webm
Impact on end user
Enables the user to add or remove members more easily
How to test
Also, using the Confirm as before works as usual
Risk
Tick one:
Worst case the new feature doesn't work