feat(community): add option to see community rules #17022
+84
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (7)
|
jrainville
force-pushed
the
feat/view-community-rules
branch
from
04a9a3b to
a4c2fd2
Compare
|
@caybro thanks for the review. Your points are fixed |
caybro
approved these changes
Jan 6, 2025
alexjba
reviewed
Jan 8, 2025
Fixes #16826 Adds the option to see the community rules in the community context menu on the left. Also adapts a few things according to designs
jrainville
force-pushed
the
feat/view-community-rules
branch
from
a4c2fd2 to
46652fe
Compare
alexjba
approved these changes
Jan 9, 2025
jrainville
requested review from
a team and
iurimatias
and removed request for
a team
|
@alexjba sorry, you've been selected again 😅 It seems like the randomizer likes you a lot. To be fair, you test well, so it's good 😄 |
|
@alexjba friendly reminder to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16826
Adds the option to see the community rules in the community context menu on the left.
Also adapts a few things according to designs.
Affected areas
Community context menu
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Design:
App:
Impact on end user
It's now possible to see the community rules after joining
How to test
Risk
Tick one:
Worst case: 🤷