fix(perf): Optimize token prices propagation #17066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
approved these changes
Jan 14, 2025
Jenkins Builds
|
alexjba
requested review from
Cuteivist,
alaibe,
dlipicar and
saledjenic
and removed request for
a team
saledjenic
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
The full solution to this issue (and maybe to a lot of wallet related UI perf issues) would be to send granular QML updates only for values that have actually changed. But this implies extensive nim+qml refactoring.
Yes, that's it and yes that requires refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes #16994
Check if something has actually change in prices before reseting the wallet.
This would be the first line of defense for token prices updates. It seems to be enough for the send modal performance improvements.
The full solution to this issue (and maybe to a lot of wallet related UI perf issues) would be to send granular QML updates only for values that have actually changed. But this implies extensive nim+qml refactoring.
Affected areas
SendModal
SwapModal