Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: remove rps limiter #5952

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

friofry
Copy link
Contributor

@friofry friofry commented Oct 16, 2024

rpc/client/chain will now not check the RPS limits before executing a call

Closes #5942

@status-im-auto
Copy link
Member

status-im-auto commented Oct 16, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ b1c4588 #1 2024-10-16 12:53:31 ~3 min tests 📄log
✔️ b1c4588 #1 2024-10-16 12:54:55 ~4 min linux 📦zip
✔️ b1c4588 #1 2024-10-16 12:55:11 ~5 min ios 📦zip
✔️ b1c4588 #1 2024-10-16 12:55:28 ~5 min tests-rpc 📄log
✔️ b1c4588 #1 2024-10-16 12:55:37 ~5 min android 📦aar
89763b3 #2 2024-10-16 13:08:26 ~50 sec android 📄log
89763b3 #2 2024-10-16 13:08:34 ~54 sec ios 📄log
89763b3 #2 2024-10-16 13:08:35 ~53 sec linux 📄log
✖️ 89763b3 #2 2024-10-16 13:09:24 ~1 min tests 📄log
✖️ 89763b3 #2 2024-10-16 13:09:44 ~2 min tests-rpc 📄log

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 10.57%. Comparing base (fadce93) to head (b1c4588).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
rpc/chain/ethclient/rps_limited_eth_client.go 50.00% 1 Missing ⚠️
services/wallet/transfer/commands_sequential.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fadce93) and HEAD (b1c4588). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fadce93) HEAD (b1c4588)
unit 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #5952       +/-   ##
============================================
- Coverage    47.14%   10.57%   -36.57%     
============================================
  Files          840      831        -9     
  Lines       138167   136731     -1436     
============================================
- Hits         65138    14464    -50674     
- Misses       65510   120417    +54907     
+ Partials      7519     1850     -5669     
Flag Coverage Δ
functional 10.57% <84.61%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
healthmanager/provider_errors/provider_errors.go 38.67% <ø> (-37.25%) ⬇️
...althmanager/provider_errors/rpc_provider_errors.go 54.28% <ø> (-28.58%) ⬇️
rpc/chain/client.go 39.90% <100.00%> (+11.13%) ⬆️
rpc/client.go 53.47% <100.00%> (-14.58%) ⬇️
services/wallet/transfer/controller.go 35.06% <ø> (+1.52%) ⬆️
rpc/chain/ethclient/rps_limited_eth_client.go 75.00% <50.00%> (+63.85%) ⬆️
services/wallet/transfer/commands_sequential.go 23.11% <0.00%> (-42.86%) ⬇️

... and 647 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore_: removal of internal RPS limiter for proxy providers
2 participants