Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add pl and pr classes to button component #603

Closed
wants to merge 4 commits into from
Closed

chore: Add pl and pr classes to button component #603

wants to merge 4 commits into from

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Oct 10, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f029428

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 2:39pm

@status-im-auto
Copy link
Member

status-im-auto commented Oct 10, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (2)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c52c02d #1 2024-10-10 20:35:46 ~30 sec chrome 📦zip
✔️ 5dc4c12c #2 2024-10-11 09:45:39 ~29 sec chrome 📦zip
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eb5fe3c5 #3 2024-10-11 14:38:56 ~29 sec chrome 📦zip
✔️ f029428 #6 2024-10-17 08:30:40 ~28 sec chrome 📦zip

@felicio felicio requested review from a team, jkbktl, prichodko and marcelines October 11, 2024 07:29
jkbktl
jkbktl approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@jkbktl jkbktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 🙏

prichodko
prichodko approved these changes Oct 11, 2024
View reviewed changes
packages/components/src/button/button.tsx Outdated
{
size: '24',
placement: 'before',
className: 'pl-[6px] pr-2',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className: 'pl-[6px] pr-2',
className: 'pl-2.5 pr-2',

packages/components/src/button/button.tsx Outdated
{
size: '24',
placement: 'after',
className: 'pl-2 pr-[6px]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className: 'pl-2 pr-[6px]',
className: 'pl-2 pr-2.5',

@felicio felicio closed this Oct 11, 2024
@prichodko prichodko reopened this Oct 11, 2024
@prichodko
Copy link
Collaborator

prichodko commented Oct 11, 2024 •
edited
Loading

I like this solution better because the negative margin is a bit cheeky. Can you add compound variants for when placement is undefined? The story is also better.

@felicio felicio closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelines marcelines marcelines approved these changes

@prichodko prichodko prichodko approved these changes

@jkbktl jkbktl jkbktl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felicio @status-im-auto @prichodko @jkbktl @marcelines