Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #640

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Release #640

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7b47d2
u
felicio Nov 28, 2024
01af36f
u
felicio Nov 28, 2024
e7bea50
f
felicio Nov 28, 2024
10fb7ac
u
felicio Dec 4, 2024
ba6d92c
u
felicio Dec 4, 2024
c338229
u
felicio Dec 4, 2024
69b6a55
u
felicio Dec 4, 2024
3c778ed
u
felicio Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/connector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,18 @@ Firefox Developer Edition > Tools > Add-ons and Themes > click on gear icon (Too

> Note: Does not reload automatically, requires build and load on change.

### Status Desktop

#### Run

##### macOS

```bash
FLAG_CONNECTOR_ENABLED=1 '/Volumes/Status Desktop/Status.app/Contents/MacOS/nim_status_client'
```

> Tip: Point to the installer package location without dropping and replacing current app.

## Testing

Download latest build from last merged PR or build from source. To use the extension see the load steps from [Development](#development) section.
4 changes: 2 additions & 2 deletions apps/connector/package.json
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pop-up placement in designs and (store) illustrations https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r?node-id=2006-23045&m=dev#916085353.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add context tag/update title https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r?node-id=3178-4916&m=dev#917687801.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update chain selection on desktop https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r?node-id=2009-321&m=dev#917714142.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in desktop, not in designs.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unsupported network state from designs https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r?node-id=2013-3377&m=dev#917718456.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix default wallet flow https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r?node-id=2013-3933&m=dev#917753970.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match logo shape in pop-up and toolbar https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r?node-id=2006-23045&m=dev#919561724.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add avatar initials when favicon is not set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trigger pop-up on disconnection https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r/Status-connector?node-id=2013-6554&m=dev.

Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
},
"manifest": {
"manifest_version": 3,
"name": "A wallet connector by Status BETA",
"description": "THIS EXTENSION IS FOR BETA TESTING. Status Desktop Wallet extended to decentralised applications in your browser.",
"name": "A wallet connector by Status",
"description": "Status Desktop Wallet extended to decentralised applications in your browser.",
"host_permissions": [
"https://*/*",
"https://chromewebstore.google.com/*"
Expand Down
6 changes: 6 additions & 0 deletions apps/connector/src/contents/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,12 @@ export class Provider {
this.#listeners.delete(event)
}

public async enable() {
console.log('enable::')

return true
}

private async disconnect() {
if (!this.connected) {
return
Expand Down