New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add `values` method to `array/complex64` #1706

Merged

kgryte merged 15 commits into stdlib-js:develop from Jaysukh-409:values

Apr 14, 2024

Member

Jaysukh-409 commented Mar 5, 2024

Description

What is the purpose of this pull request?

This pull request:

Adds the typed array values method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          feat: add values method to array/complex64

46ab581

kgryte added the Enhancement label

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

d8ac3d4

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.values.js Outdated Show resolved Hide resolved

kgryte requested changes

View reviewed changes

Member

kgryte left a comment

Thanks for working on this @Jaysukh-409. Left a few comments.

Jaysukh-409 and others added 3 commits

March 7, 2024 17:28


          feat: updated implementation and test

2ec8bd0


          Apply suggestions from code review

52589d8

Signed-off-by: Athan <[email protected]>


          Apply suggestions from code review

e25a21a

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.values.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.values.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.values.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.values.js Outdated Show resolved Hide resolved


          Apply suggestions from code review

bc6c394

Signed-off-by: Athan <[email protected]>

kgryte requested changes

View reviewed changes

Member

kgryte left a comment

@Jaysukh-409 Did another review. The implementation still needs some updates along with associated tests.

Jaysukh-409 added 2 commits

April 13, 2024 14:56


          feat: apply suggestion

e94ea67


          Merge branch 'values' of https://github.com/Jaysukh-409/stdlib into v…

…alues

kgryte self-assigned this

kgryte self-requested a review

April 14, 2024 09:20

kgryte added 3 commits

April 14, 2024 02:24


          bench: update description

d0adae6


          refactor: improve type specificity for entries

263453a


          fix: handle early iterator return

5b9ee13

kgryte added 4 commits

April 14, 2024 02:41


          refactor: update entries to use internal helper function

20d859c


          test: refactor and reorganize test cases

7c05771


          docs: document property and update copy for entries

4c7e441


          docs: fix headings

29938ae

kgryte approved these changes

View reviewed changes

kgryte merged commit 832504a into stdlib-js:develop

8 checks passed

Jaysukh-409 deleted the values branch

June 11, 2024 07:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels