Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

stdlib-js / stdlib Public

Notifications You must be signed in to change notification settings
Fork 595
Star 4.8k

Code
Issues 559
Pull requests 451
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update `blas/ext/base/dapx` to follow current project conventions #1954

Merged

kgryte merged 15 commits into stdlib-js:develop from naveen1m:1464-refactor

Mar 21, 2024

Merged

refactor: update `blas/ext/base/dapx` to follow current project conventions #1954

kgryte merged 15 commits into stdlib-js:develop from naveen1m:1464-refactor

Mar 21, 2024

Conversation 24 Commits 15 Checks 12 Files changed

Conversation

Copy link

Contributor

naveen1m commented Mar 19, 2024 •

edited by kgryte

Loading

Resolves #1464

Description

What is the purpose of this pull request?

This pull request:

Refactors @stdlib/blas/ext/base/ssorthp to follow current project conventions.

Checklist

update README.md
manifest.json
include.gypi
benchmark
examples
docs
test
src
lib

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: refactor blas/ext/base/dapx to follow current project conventions #1464
progresses Refactor and update existing extended base BLAS packages according to current project conventions #1152

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Sorry, something went wrong.

All reactions

naveen1m added 7 commits

March 18, 2024 20:45


          refactor: /blas/ext/base/dapx/ to follow current project convention


          refactor: update addon.cpp to addon.c

7134d6a


          refactor: /blas/ext/base/dapx/ to follow current project convention

e5d14ea


          refactor: /blas/ext/base/dapx/ to follow current project convention

c7e1b7d


          refactor: /blas/ext/base/dapx/lib/ to follow current project convention

864933c


          refactor: /blas/ext/base/dapx/test/ to follow current project convention

4e96443


          refactor: /blas/ext/base/dapx/benchmark/ to follow current project co…

8afc4c3

…nvention

stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label

naveen1m changed the title ~~refactor: update /blas/ext/base/dapx/l to follow current project conventions~~ refactor: update /blas/ext/base/dapx/ to follow current project conventions

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/README.md Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/docs/repl.txt Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/examples/index.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/manifest.json Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/src/addon.c Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/src/addon.c Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/src/addon.c Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/src/addon.c Outdated Show resolved Hide resolved


          docs: update descriptions and examples

3369a2a

Signed-off-by: Athan <[email protected]>

kgryte requested changes

View reviewed changes

Copy link

Member

kgryte left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @naveen1m! Left an initial round of comments.

Sorry, something went wrong.

All reactions

kgryte requested changes

View reviewed changes

Copy link

Member

kgryte left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @naveen1m! Left an initial round of comments.

Sorry, something went wrong.

All reactions

Planeshifter changed the title ~~refactor: update /blas/ext/base/dapx/ to follow current project conventions~~ refactor: update /blas/ext/base/dapx to follow current project conventions

Planeshifter changed the title ~~refactor: update /blas/ext/base/dapx to follow current project conventions~~ refactor: update blas/ext/base/dapx to follow current project conventions

kgryte added Enhancement

Issue or pull request for enhancing existing functionality.

Issue involves or relates to Node.js native add-ons.

C Issue involves or relates to C. labels

kgryte added the Needs Changes Pull request which needs changes before being merged. label

naveen1m added 3 commits

March 20, 2024 11:55


          refactor: update blas/ext/base/dapx/ to follow current project conven…

d9ec7ce

…tion


          fix: update build configuration

a4847a1


          Merge branch '1464-refactor' of github.com:naveen1m/stdlib into 1464-…

ae2d79f

…refactor

 This merge brings in the following chnages:
  - update docs/

Copy link

Contributor Author

naveen1m commented Mar 20, 2024

@kgryte Made chnages for the requested file please review it!

All reactions

Sorry, something went wrong.


          docs: update example

53ea320

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/examples/index.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/examples/index.js Outdated Show resolved Hide resolved


          Apply suggestions from code review

df9f677

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/manifest.json Outdated Show resolved Hide resolved


          Apply suggestions from code review

9ddf8a0

Signed-off-by: Athan <[email protected]>

kgryte approved these changes

View reviewed changes

Copy link

Member

kgryte left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @naveen1m!

Sorry, something went wrong.

All reactions

kgryte removed the Needs Changes Pull request which needs changes before being merged. label

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/dapx/examples/index.js Outdated Show resolved Hide resolved


          Apply suggestions from code review

824a39a

Signed-off-by: Athan <[email protected]>

kgryte merged commit 0d2528e into stdlib-js:develop

8 checks passed

Copy link

Contributor Author

naveen1m commented Mar 21, 2024

Thanks for the review and merge, @kgryte!

All reactions

Sorry, something went wrong.

naveen1m mentioned this pull request

[RFC]: build a developer dashboard for tracking repository build status stdlib-js/google-summer-of-code#67

Closed

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS

Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

C

Issue involves or relates to C.

Issue or pull request for enhancing existing functionality.

Issue involves or relates to Node.js native add-ons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dapx to follow current project conventions

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.