-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constants/float64/num-high-word-significand-bits
#2889
feat: add constants/float64/num-high-word-significand-bits
#2889
Conversation
In terms of naming conventions, we have a couple of (semi-)relevant precedents:
When I first saw My personal preference would be to rename the package and constant name to make its intent more obvious. Potential names:
I think my preference is the first option, but I am open to suggestions. |
@kgryte Thanks for explaining. That definitely makes sense.
|
This pkg will be used rarely enough that length is not a huge concern. You may need to disable the ESLint rule for id-length each time the constant variable is declared in JS. |
constants/float64/high-word-significand-bits
constants/float64/num-high-word-significand-bits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi!
Description
This pull request:
constants/float64/num-high-word-significand-bits
, which would help to complete the TODO at: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/pow/src/main.c#L52.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers